Skip to content

fix: remove assets directory from Dockerfile runtime stage#238

Merged
nanotaboada merged 1 commit intomasterfrom
fix/Dockerfile
Dec 4, 2025
Merged

fix: remove assets directory from Dockerfile runtime stage#238
nanotaboada merged 1 commit intomasterfrom
fix/Dockerfile

Conversation

@nanotaboada
Copy link
Copy Markdown
Owner

@nanotaboada nanotaboada commented Dec 4, 2025

This change is Reviewable

Summary by CodeRabbit

  • Chores
    • Optimized Docker image build process by removing unnecessary asset directory copy from the runtime stage. No functional changes to application behavior or performance.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Dec 4, 2025

Walkthrough

This change removes a COPY instruction from the runtime stage of the Dockerfile that copies the assets directory with restricted permissions. No other build or runtime steps are affected.

Changes

Cohort / File(s) Summary
Docker build configuration
Dockerfile
Removed COPY instruction for assets directory from runtime stage (COPY --chmod=555 assets/ ./assets/)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: removing the assets directory copy command from the Dockerfile runtime stage.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/Dockerfile

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 069a45d and dfa6ee0.

📒 Files selected for processing (1)
  • Dockerfile (0 hunks)
💤 Files with no reviewable changes (1)
  • Dockerfile
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: Codacy Static Code Analysis
  • GitHub Check: Analyze (java-kotlin)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Dec 4, 2025

@codacy-production
Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
+0.00% (target: -1.00%)
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (069a45d) 55 55 100.00%
Head commit (dfa6ee0) 55 (+0) 55 (+0) 100.00% (+0.00%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#238) 0 0 ∅ (not applicable)

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (069a45d) to head (dfa6ee0).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##              master      #238   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
  Complexity        22        22           
===========================================
  Files              2         2           
  Lines             55        55           
  Branches           4         4           
===========================================
  Hits              55        55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@nanotaboada nanotaboada merged commit 6ad9ecb into master Dec 4, 2025
17 checks passed
@nanotaboada nanotaboada deleted the fix/Dockerfile branch December 4, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant